[oneDPL] Add set parallel range algorithms #630
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
danhoeflinger
approved these changes
Aug 6, 2025
akukanov
reviewed
Aug 14, 2025
source/elements/oneDPL/source/parallel_api/parallel_range_api.rst
Outdated
Show resolved
Hide resolved
Co-authored-by: Alexey Kukanov <[email protected]>
akukanov
approved these changes
Aug 15, 2025
danhoeflinger
approved these changes
Aug 15, 2025
Comment on lines
+454
to
+456
| std::ranges::set_difference_result<std::ranges::borrowed_iterator_t<R1>, | ||
| std::ranges::borrowed_iterator_t<R2>, | ||
| std::ranges::borrowed_iterator_t<OutR>> |
There was a problem hiding this comment.
Seems like we missed a mistake here:
std::ranges::borrowed_iterator_t<R2>, should not be here according to the paper or std::ranges::set_difference_result definition
There was a problem hiding this comment.
Good catch. I've prepared #637 to fix it.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adding
includes,set_union,set_intersection,set_difference,set_symmetric_differenceparallel range algorithms into oneDPL specification.